(feat): Adding new quick-select dialog #2552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new quick-select dialog much akin to the Command Palette, except instead of selecting commands, it fuzzy finds on node name/path. This somewhat improves the UX, in my opinion, for quickly switching nodes. There is the `Ctrl+T` shortcut for "Find in Multiple Nodes...", but that search box does not have suggestions or live filtering. The inspiration for this feature comes from the `Ctrl+P` default binding in VS Code where you can search for a file very quickly and switch to it. I have put a default binding of `Ctrl+Alt+P` in, but that is a very rough "what I could find that wasn't already used" kind of map and I am very open to changing it. Also note, if there is some reason this feature hasn't been in CherryTree I am happy to abandon the PR. I just think it might make a really cool addition.
ericguin
commented
Aug 10, 2024
src/ct/ct_dialogs_sel_node.cc
Outdated
| { | ||
| auto ctit = treeStore.to_ct_tree_iter(iter); | ||
| auto full_path = CtMiscUtil::get_node_hierarchical_name(ctit, " / ", false); | ||
| spdlog::debug("Node path for {} in ints is: {}", ctit.get_node_name(), path.to_string()); |
There was a problem hiding this comment.
Left in my debug on accident
giuspen
requested changes
Aug 10, 2024
src/ct/ct_actions_file.cc
Outdated
| void CtActions::command_selnode() | ||
| { | ||
| auto id = CtDialogs::dialog_selnode(_pCtMainWin); | ||
| auto node_iter = _pCtMainWin->get_tree_store().get_node_from_node_id(id); |
There was a problem hiding this comment.
as you can return an invalid id (-1) for example if the user presses cancel on the dialog, you have to check that the returned node_iter is valid if (node_iter ) or set_cursor_safe() with a bad input will crash
There was a problem hiding this comment.
D'oh... Completely slipped my mind on that one. Even added the -1 for this very purpose
src/ct/ct_dialogs_sel_node.cc
Outdated
| @@ -0,0 +1,241 @@ | |||
| /* | |||
| * ct_dialogs_cmd_palette.cc | |||
There was a problem hiding this comment.
file name to fix after copy/paste
|
Thank you for the prompt review! Really loving this software, there's something about it that is finally making it not just easy but fun to finally start organizing my life. Much appreciated. |
|
very nice work @ericguin thanks again for sharing it, I will look for a suitable default keyboard shortcut |
giuspen
added a commit
that referenced
this pull request
Aug 11, 2024
|
This is amazing. A few notes/feedback:
Thanks again for the awesome feature! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new quick-select dialog much akin to the Command Palette, except instead of selecting commands, it fuzzy finds on node name/path.
This somewhat improves the UX, in my opinion, for quickly switching nodes. There is the
Ctrl+Tshortcut for "Find in Multiple Nodes...", but that search box does not have suggestions or live filtering.The inspiration for this feature comes from the
Ctrl+Pdefault binding in VS Code where you can search for a file very quickly and switch to it. I have put a default binding ofCtrl+Alt+Pin, but that is a very rough "what I could find that wasn't already used" kind of map and I am very open to changing it.Also note, if there is some reason this feature hasn't been in CherryTree I am happy to abandon the PR. I just think it might make a really cool addition.