Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove statically-defined users from application seeder #500

Closed
mattyg opened this issue Jun 24, 2022 · 0 comments · Fixed by #520
Closed

Remove statically-defined users from application seeder #500

mattyg opened this issue Jun 24, 2022 · 0 comments · Fixed by #520
Assignees
@nebs-dev
Labels
api bug Something isn't working

Comments

@mattyg
Copy link
Collaborator

mattyg commented Jun 24, 2022

In #479 the seeder functions were refactored significantly.

Continuing on that work, we should remove the PREDEFINED_USERS from seeder/app.ts, instead relying on the seedAdminUsers() function which generates admin users from process.env.ADMINS.

This ensures that our pre-defined set of admins (from the TEC and praise dev team) are not automatically made admins in other communities production deployments.
@mattyg mattyg added bug Something isn't working api labels Jun 24, 2022
@nebs-dev nebs-dev mentioned this issue Jul 21, 2022
Merged
kristoferlund added a commit that referenced this issue Jul 25, 2022
@kristoferlund
Merge pull request #520 from commons-stack/bug/statically_defined_use…
79da47e 
…rs_in_seeder

Remove statically-defined users from application seeder #500
@kristoferlund kristoferlund mentioned this issue Aug 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nebs-dev nebs-dev

Labels
api bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove statically-defined users from application seeder #500 givepraise/praise
2 participants
@mattyg @nebs-dev