Praising does not work in threads

[kristoferlund]

No description provided.

[Vyvy-vi]

It looks like this issue needs some testing to verify if there's a problem.
I just tested a local instance of praise (synced with the latest changes to main), and praising worked in threads.

[gideonro]

Any updates on this issue? We were hoping to set up a thread for doing Sampo-specific Praise so that it doesn't clog our main channel.

More importantly though, we want to see if there's a way to use Praise to recognize good contributions to the new TEC Curation Service. The service relies on the new Discord Forum tool (which relies on threads).

[kristoferlund]

@Vyvy-vi you mentioned today issue might be solved with upgrading to new version of discord.js, did I get that correctly? The audio quality during the call was quite noisy.

[Vyvy-vi]

Yes, it might be fixed.
Praise is working in threads in my local build of #619, and was also working before that(since #569).
After #619 is merged and TEC's instance is updated to the latest praise version., we can test and check if praising works in threads. If it still doesn't work, we might need to debug the TEC instance separately to check what's erroring out.

[Vyvy-vi]

After attempting to debug it on the TEC instance, I found that this is a permission issue. The bot wasn't able to run /praise in the thread unless it had administrator permissions, as it can't join the private thread by default unless it has admin perms.

I've added the perms to the bot in TEC so praise should be usable in threads for now 👍 (though I'd recommend waiting for #619 to get merged).

[Vyvy-vi]

We need to add a permission check to the praise commands and relevant error messages, that ensure that the users can correct their config(or the bot adjusts itself so that admin perms aren't needed)