Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to discord.js v14 #619

Merged
merged 11 commits into from
Oct 7, 2022
Merged

Update to discord.js v14 #619

merged 11 commits into from
Oct 7, 2022

Conversation

Vyvy-vi
Copy link
Collaborator

@Vyvy-vi Vyvy-vi commented Oct 4, 2022 •
edited by kristoferlund
Loading

  • This Pr bumps the discord.js version and fixes all the breaking changes
  • There are also some minor refactors to make things cleaner

Added by Kristofer

kristoferlund
kristoferlund requested changes Oct 5, 2022
View reviewed changes
Copy link
Member

@kristoferlund kristoferlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Use format channel name / thread name for sourceName

@Vyvy-vi Vyvy-vi requested a review from kristoferlund October 5, 2022 20:42
@Vyvy-vi Vyvy-vi force-pushed the chore/525/update-to-discord.jsv14 branch 2 times, most recently from a2e3a05 to 79867e2 Compare October 6, 2022 03:54
@Vyvy-vi Vyvy-vi force-pushed the chore/525/update-to-discord.jsv14 branch from 79867e2 to cc49cfa Compare October 6, 2022 03:58
@Vyvy-vi Vyvy-vi mentioned this pull request Oct 6, 2022
Closed
kristoferlund
kristoferlund approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@kristoferlund kristoferlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Merging

@kristoferlund kristoferlund merged commit 22a8ba7 into main Oct 7, 2022
@kristoferlund kristoferlund deleted the chore/525/update-to-discord.jsv14 branch October 7, 2022 08:15
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.0% 2.0% Duplication

@kristoferlund kristoferlund mentioned this pull request Oct 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristoferlund kristoferlund kristoferlund approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Praising does not work in threads
2 participants
@Vyvy-vi @kristoferlund