Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin should be able to reset settings to default values in the praise dashboard settings interface #580

Closed
kristoferlund opened this issue Sep 14, 2022 · 2 comments · Fixed by #613
Closed

Admin should be able to reset settings to default values in the praise dashboard settings interface #580

kristoferlund opened this issue Sep 14, 2022 · 2 comments · Fixed by #613
Assignees
@kkatusic
Labels
api dashboard enhancement New feature or request

Comments

@kristoferlund
Copy link
Member

kristoferlund commented Sep 14, 2022 •
edited
Loading

  • On hover on the title of a setting, an icon button appears that allows an admin to reset a setting to the default value: image
  • Button looks and works similar to the quantifier replacement button: image
  • Add defaultValue to API interface Setting and SettingDto.
  • Populate all default values using a database migration
  • Use the /settings/:id/set to reset value, or create new endpoint /settings/:id/reset
@kristoferlund kristoferlund changed the title Reset settings to default values Admin should be able to reset settings to default values in the praise dashboard settings interface Sep 14, 2022
@kristoferlund kristoferlund added enhancement New feature or request api dashboard labels Sep 14, 2022
@kristoferlund
Copy link
Member Author

@kkatusic I added som detail to this issue, see 👆👆

@kkatusic kkatusic mentioned this issue Oct 2, 2022
Merged
@kkatusic
Copy link
Collaborator

@kristoferlund I changed icon/button behaviour and find some tiny bug, please remove last migration and re-test, thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkatusic kkatusic

Labels
api dashboard enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add/setting default values givepraise/praise
2 participants
@kkatusic @kristoferlund