Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/setting default values #613

Merged
merged 18 commits into from
Oct 17, 2022
Merged

Add/setting default values #613

merged 18 commits into from
Oct 17, 2022

Conversation

kkatusic
Copy link
Collaborator

@kkatusic kkatusic commented Oct 2, 2022 •
edited
Loading

Closes #580

@kristoferlund I need review. I didn't attached some fields and checkboxes. thx

@kkatusic kkatusic self-assigned this Oct 2, 2022
kristoferlund and others added 5 commits October 7, 2022 23:26
@kristoferlund
Merge branch 'main' into add/setting_default_values
867fddb
@kristoferlund
Add defaultValue to genericSettingsSchema
cadb2b2
@kkatusic
Default values settings entitles added
861bc2c 
Also created button and added icon for default value reseting.

Created "mutator" inside Form component, it contain setValue function for changing current field function ;)
@kkatusic
Set up return value for function
9694843
@kkatusic
Fixed typescript error
61dd68e
@kkatusic kkatusic changed the title WIP: Add/setting default values Add/setting default values Oct 12, 2022
kristoferlund
kristoferlund requested changes Oct 14, 2022
View reviewed changes
Copy link
Member

@kristoferlund kristoferlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I made some small change to default values and texts.

One thing I would like to adjust. Let's make the reset buttons invisible until you hover the setting name. And also do mouseover effect similar to how it is done on periods / quantifiers page.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.0% 1.0% Duplication

@kristoferlund kristoferlund self-requested a review October 17, 2022 09:01
kristoferlund
kristoferlund approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@kristoferlund kristoferlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @kkatusic! Merging

@kristoferlund kristoferlund merged commit 09df00d into main Oct 17, 2022
@kristoferlund kristoferlund deleted the add/setting_default_values branch October 17, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristoferlund kristoferlund kristoferlund approved these changes

Assignees

@kkatusic kkatusic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Admin should be able to reset settings to default values in the praise dashboard settings interface
2 participants
@kkatusic @kristoferlund