-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve dapp responsiviness #356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Thank you so much for fixing #80 too!
I think there's a few more changes in #190 we might want to think about:
-
What do you think about picking a standard max width for every page? Currently there are some with
max-w-2xl
,max-w-4xl
, andmax-w-5xl
. I feel like this causes a bit weird, jumpy UX when the user navigates to a different page, and the content area jumps to a different width. But it's also a UX pattern you see in a lot of sites. Any thoughts on it? I'm really not sure what the best approach is. -
At the very least, if we don't want to increase the max width of all pages, lets increase it for the
PeriodDetailsPage
which has a lot of content and feels a bit "tight". -
refactoring the QuantifyTable component from a table to divs, so that it can be made more responsive in smaller screens. On a smaller screen, the columns could be split into two rows, with a bit more spacing between each list item. Something like this wireframe: https://wireframe.cc/SVaaNp -- do you think that would be preferable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great @pkretzschmar! I'm merging this now, let's revisit the topic when we switch to top navigation. We might need to make additional changes then.
Improve app responsiviness specially for mobile devides. Fix #190
Fix #80