Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Require discord role option #440

Merged
merged 8 commits into from
Jun 8, 2022
Merged

Feat: Require discord role option #440

merged 8 commits into from
Jun 8, 2022

Conversation

kristoferlund
Copy link
Member

Closes #434
Closes #419

  • Add option to enable/disable the requirement to assign a certain Discord role to users before they can praise.
  • Centralise the logic for the Discord role check to one function assertPraiseGiver.

@kristoferlund kristoferlund requested review from Vyvy-vi and mattyg June 3, 2022 22:32
mattyg
mattyg previously requested changes Jun 5, 2022
View reviewed changes
Copy link
Collaborator

@mattyg mattyg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Just requested one minor change inline

@kristoferlund kristoferlund requested a review from mattyg June 7, 2022 11:08
@kristoferlund kristoferlund merged commit 7a0f5fe into main Jun 8, 2022
@kristoferlund kristoferlund deleted the feat/require_discord_role_option branch June 8, 2022 09:24
@kristoferlund kristoferlund mentioned this pull request Jun 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vyvy-vi Vyvy-vi Awaiting requested review from Vyvy-vi

@mattyg mattyg Awaiting requested review from mattyg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kristoferlund @mattyg