Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/option assign all quantifiers #456

Merged
merged 14 commits into from
Jun 15, 2022

Conversation

mattyg
Copy link
Collaborator

@mattyg mattyg commented Jun 7, 2022

Resolves #263

Overview

  • Fork package greedy-number-partitioning, add support for arrays of arbitrary objects and convert module to typescript
  • Add dependency greedy-number-partitioning
  • add setting PRAISE_QUANTIFIERS_ASSIGN_ALL
  • Implemented function to assign praise to all quantifiers evenly, using a "Multiway number partitioning" algorithm ( https://en.wikipedia.org/wiki/Multiway_number_partitioning ), when PRAISE_QUANTIFIERS_ASSIGN_ALL enabled

Note the dependency greedy-number-partitioning is currently a forked version, held on my personal github account. I opened a PR with the package maintainer, but we may want to move the repo to github.com/commons-stack in the meantime.

@mattyg mattyg requested review from kristoferlund and removed request for kristoferlund June 7, 2022 23:07
Copy link
Member

@kristoferlund kristoferlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Really like the cleanup and move to assignment.ts! Merging.

@kristoferlund kristoferlund merged commit fa64cb2 into main Jun 15, 2022
@kristoferlund kristoferlund deleted the feat/option_assign_all_quantifiers branch June 15, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to make quantifier assignment manual
2 participants