-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/option assign all quantifiers #456
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tifiersDryRun, currently non-deterministic
…for clearer code organization
…o different assignment algorithms, call either depending on PRAISE_QUANTIFIERS_ASSIGN_ALL
…en PRAISE_QUANTIFIERS_ASSIGN_ALL=true
…LL, and bump migration number
kristoferlund
approved these changes
Jun 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! Really like the cleanup and move to assignment.ts
! Merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #263
Overview
greedy-number-partitioning
, add support for arrays of arbitrary objects and convert module to typescriptgreedy-number-partitioning
PRAISE_QUANTIFIERS_ASSIGN_ALL
PRAISE_QUANTIFIERS_ASSIGN_ALL
enabledNote the dependency
greedy-number-partitioning
is currently a forked version, held on my personal github account. I opened a PR with the package maintainer, but we may want to move the repo to github.com/commons-stack in the meantime.