Code

Feat: replace active quantifier#503

Code

Merged

kristoferlund merged 32 commits intomaingivepraise/praise:mainfrom feat/replace_active_quantifiergivepraise/praise:feat/replace_active_quantifierCopy head branch name to clipboardJun 29, 2022

+1,091-323

Commits

Commits on Jun 22, 2022

• fix(api): remove check to verify that *all* quantifiers were assigned to a bucket of praise in 'prepareAssignmentsByAllQuantifiers()' - as this is impossible if there are more quantifiers in pool t…

  Show description for 9332450
  mattyg

  committed
  9332450

  Copy full SHA for 9332450

• chore(api): remove unnecessary logging

  mattyg

  committed
  fa1d935

  Copy full SHA for fa1d935

• fix(api): replace setting PRAISE_QUANTIIFIERS_ASSIGN_ALL with PRAISE_QUANTIFIERS_ASSIGN_EVENLY to clarify that the algorithm cannot assign *all* quantifiers in some conditions (such as if there are…

  Show description for 14709b0
  mattyg

  committed
  14709b0

  Copy full SHA for 14709b0

• chore: changelog

  mattyg

  committed
  594ae3f

  Copy full SHA for 594ae3f

• chore: changelog re-wording

  mattyg

  committed
  74c2814

  Copy full SHA for 74c2814

Commits on Jun 26, 2022

• chore(frontend): delete unused component

  mattyg

  committed
  af61fab

  Copy full SHA for af61fab

• chore(frontend): remove unncessary function call wrappers

  mattyg

  committed
  604aa63

  Copy full SHA for 604aa63

• refactor(frontend): delete MarkDuplicateButton, MarkDismissedButton -- replace with generic IconButton

  mattyg

  committed
  8a7f06e

  Copy full SHA for 8a7f06e

• feat(api): period controller to replace a quantifier

  mattyg

  committed
  a02d54b

  Copy full SHA for a02d54b

• feat(frontend): UX to replace an active quantifier with another that is unassigned

  mattyg

  committed
  a60dc4f

  Copy full SHA for a60dc4f

• chore: remove no longer needed cli command 'replace-quantifier'

  mattyg

  committed
  f95da2a

  Copy full SHA for f95da2a

Commits on Jun 27, 2022

• fix(frontend): typo on tailwind class name

  mattyg

  committed
  9551bc9

  Copy full SHA for 9551bc9

• style(frontend): make SelectUserRadioGroup expand height up to max size

  mattyg

  committed
  090110e

  Copy full SHA for 090110e

• refactor(frontend): remove headlessui Popover from UserPopover, as it was not actually being used (it only supports click-based popovers)

  mattyg

  committed
  269be5d

  Copy full SHA for 269be5d

• style(frontend): support dark mode in SelectUserRadioGroup

  mattyg

  committed
  0e26fb7

  Copy full SHA for 0e26fb7

• fix(api): ensure that quantification scores are completely reset when quantifier is replaced

  mattyg

  committed
  7597797

  Copy full SHA for 7597797

• refactor(api): use getPeriodDateRangeQuery to reduce duplicate logic

  mattyg

  committed
  eba1fa2

  Copy full SHA for eba1fa2

• fix(frontend): display Notice when no unassigned quantifiers are available as replcements

  mattyg

  committed
  b963d21

  Copy full SHA for b963d21

• chore: changelog

  mattyg

  committed
  8d86635

  Copy full SHA for 8d86635

• fix: after replacing quantifier, update both period and affected praises in frontend store, to ensure praise quantification data is fresh

  mattyg

  committed
  9ab0fac

  Copy full SHA for 9ab0fac

• feat(frontend): support replacing quantifier with another active quantifier (i.e. doubling up on their assignments)

  mattyg

  committed
  25426e4

  Copy full SHA for 25426e4

• style(frontend): specify dark / light mode text color in UserPopover

  mattyg

  committed
  915ef74

  Copy full SHA for 915ef74

• fix(api): log the user who called replaceQuantifier

  mattyg

  committed
  7f55486

  Copy full SHA for 7f55486

Commits on Jun 28, 2022

• Styling adjustments

  kristoferlund

  committed
  d229cdc

  Copy full SHA for d229cdc

• Merge branch 'main' into fix/allow_even_quantifier_assignment_when_too_many_quantifiers

  kristoferlund

  committed
  e3c7fe4

  Copy full SHA for e3c7fe4

• test(api): fix settings and periodsettings tests - use seeded settings rather than expecting 'real' settings from migrations to exist

  mattyg

  committed
  f5fe398

  Copy full SHA for f5fe398

• Merge branch 'fix/allow_even_quantifier_assignment_when_too_many_quantifiers' into feat/replace_active_quantifier

  mattyg

  committed
  076ba41

  Copy full SHA for 076ba41

• fix(api): prevent replacing quantifier with another that is already assigned to some of the original quantifier's praise

  mattyg

  committed
  a6b57f6

  Copy full SHA for a6b57f6

• fix(frontend): clear selected user after submit in ReplaceQuantifierDialog

  mattyg

  committed
  63e45e4

  Copy full SHA for 63e45e4

• feat(frontend): exclude the original quantifier from the list of possible replacements in ReplaceQuantifierDialog

  mattyg

  committed
  75c975b

  Copy full SHA for 75c975b

• fix(frontend): update replace quantifier success message to indicate the their scores are reset

  mattyg

  committed
  dd7601f

  Copy full SHA for dd7601f

• test(api): tests for replaceQuantifiers controller

  mattyg

  committed
  830d0cb

  Copy full SHA for 830d0cb