Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recoil upgrade and overall refactor of frontend #523

Merged
merged 31 commits into from
Jul 26, 2022
Merged

Recoil upgrade and overall refactor of frontend #523

merged 31 commits into from
Jul 26, 2022

Conversation

kristoferlund
Copy link
Member

@kristoferlund kristoferlund commented Jul 25, 2022 •
edited
Loading

  • Upgraded Recoil to latest version to get access to more solid support for effects
  • Replace selectors/hooks that initialise atoms with atoms that self initialise: user, period, periodsettings, settings.
  • Refactoring of all selectors, atoms and api hooks:
    • More consistent naming
    • More consistent typing
    • Remove unused functions: ApiQuery, useAuthApiQuery
    • Added AccessToken selector
    • Replaced eventlog hooks with selectors because of infinite loop issue
  • Periods
  • Final Form:
    • Use built-in error handling
  • Error boundaries / Suspense
    • Removed some suspense points at the component level
    • Added a suspense point at page content level to minimise flicker on page load

@kristoferlund
Upgrade Recoil
697691e
@kristoferlund
Add initialisation logic to AllUsers atom
993ea38
@kristoferlund
Remove user preload, to be replaced with other construction
e23a0da
@kristoferlund
Make sure Settings and PeriodSettings use Recoil best practices
3b1e628
@kristoferlund
Fix missing key error
d06bb0e
@kristoferlund
Use integrated final-form error handling
cb8d815
@kristoferlund
Move pool requirements check to AssignDialog
c60e75a
@kristoferlund
Use recoil effects to initialise period atom
a5f643f
@kristoferlund
Return error from handleErrors
6ece230
@kristoferlund
Remove ApiQuery and useAuthApiQuery
abd10ce
@kristoferlund
Cleanup usage of api client
d74eb26
@kristoferlund
Add AccessToken atom
fa4ece8
@kristoferlund
Pre-load settings to force ApiAuthGet to initialise properly
01afe0d
@kristoferlund
Replace effects_UNSTABLE with effects
5a0d95a
@kristoferlund
Add generics to better handle return type of isResponseOk
900b3c3
@kristoferlund
Continued refactoring
46ee638
@kristoferlund
Remove unnecessary Suspense
9b77d59
@kristoferlund
Comment out api loading delay
bba5b40
@kristoferlund
Better praise loader margins
5b90414
@kristoferlund
Delete console.log statements
85d3810
@kristoferlund
Use promise based setSelf to ensure suspense works
11afa68
@kristoferlund
Separate metamask load delay and theme handling
f6b1bfc
@kristoferlund
Hide quantification box when not assigned as quantifier
04d5a49
@kristoferlund
Reduce flickering on page switch
e76e729
@kristoferlund
Replace hooks with Recoil selectors, prevent endless loops
1d86d39
@kristoferlund
Ensure user icons are correct size
12708d2
@kristoferlund
Only show quant message when quantification is open
2d2df43
@kristoferlund
User popovers should not display when pseudonyms are used
a52e6b0
@kristoferlund
Renaming and comments
2611366
@kristoferlund kristoferlund changed the title Refactor/recoil upgrade Recoil upgrade and overall refactor of frontend Jul 25, 2022
@kristoferlund kristoferlund merged commit 628168a into main Jul 26, 2022
@kristoferlund kristoferlund deleted the refactor/recoil_upgrade branch July 26, 2022 18:07
@kristoferlund kristoferlund mentioned this pull request Aug 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changes to Period settings are not reflected in the Assign quantifiers dialog
1 participant
@kristoferlund