Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/analytics dark mode #570

Merged
merged 7 commits into from
Sep 1, 2022
Merged

UI/analytics dark mode #570

merged 7 commits into from
Sep 1, 2022

Conversation

kristoferlund
Copy link
Member

Some minor changes to the Analytics page to better handle dark mode and chart.js errors.

@kristoferlund
Copy link
Member Author

@kkatusic I put the error boundary thing I mentioned in this PR instead of pushing it to yours.

@kristoferlund kristoferlund requested a review from nebs-dev August 31, 2022 16:22
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kkatusic
Copy link
Collaborator

@kkatusic I put the error boundary thing I mentioned in this PR instead of pushing it to yours.

I found it: https://github.com/commons-stack/praise/blob/ui/analytics_dark_mode/packages/frontend/src/pages/Periods/Details/components/Analytics.tsx

Thx

@kristoferlund kristoferlund merged commit 2e85d1e into main Sep 1, 2022
@kristoferlund kristoferlund deleted the ui/analytics_dark_mode branch September 14, 2022 17:38
@kristoferlund kristoferlund mentioned this pull request Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants