Fix/evenly assign quantifiers prevent overlap #573
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #535
prepareAssignmentsEvenly
to prevent a case where a quantifier could be assigned to the same receiver twiceprepareAssignmentsEvenly
Post-Mortem
Previously in
prepareAssignmentsEvenly
we:This allowed a case where a quantifier could be assigned a duplicate receivers, because multiple groups of unique receivers could potential contain a duplicate between them.
With this refactor, we swapped the order of these steps. Now we: