Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge "my praise" into root page #615 #618

Merged
merged 3 commits into from
Oct 7, 2022
Merged

Merge "my praise" into root page #615 #618

merged 3 commits into from
Oct 7, 2022

Conversation

nebs-dev
Copy link
Contributor

@nebs-dev nebs-dev commented Oct 4, 2022

Resolves #615

  • Merged MyPraise to the start oage
  • Removed MyPraise page
  • bottom scroll bug is still unresolved, maybe we should open separate issue?

@nebs-dev nebs-dev requested a review from kristoferlund October 4, 2022 14:34
@nebs-dev nebs-dev self-assigned this Oct 4, 2022
@nebs-dev nebs-dev marked this pull request as ready for review October 5, 2022 15:25
@nebs-dev nebs-dev changed the title WIP: Merge "my praise" into root page #615 Merge "my praise" into root page #615 Oct 5, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

kristoferlund
kristoferlund approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@kristoferlund kristoferlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Made some small styling changes, now merging.

@kristoferlund kristoferlund merged commit 04932aa into main Oct 7, 2022
@kristoferlund kristoferlund deleted the my_praise_root_page branch November 18, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristoferlund kristoferlund kristoferlund approved these changes

Assignees

@nebs-dev nebs-dev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge "my praise" into root page
2 participants
@nebs-dev @kristoferlund