Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there!
I've found an error in -v / --validate-config behaviour and this code should be able to fix that.
In particular, python, afaik, doesn't have any capability to cast input arguments to boolean (so even if you would set
--validate-config True
it would be string value, not a boolean), thus Line 36 condition will fail anyway.Now it is possible to use as a normal option without passing additional argument (like
--version
ie).If you may, please, consider reviewing this promptly, 'cause we're using Yacron in kinda production environment and this type of validation is somewhat crucial for our CI/CD pipelines - our devs aren't careful enough to validate configuration on their own.
Thanks in advance.