Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate config parameter fix #57

Merged
merged 1 commit into from
Nov 19, 2021
Merged

Conversation

init-penguin
Copy link

Hello there!

I've found an error in -v / --validate-config behaviour and this code should be able to fix that.

In particular, python, afaik, doesn't have any capability to cast input arguments to boolean (so even if you would set --validate-config True it would be string value, not a boolean), thus Line 36 condition will fail anyway.

Now it is possible to use as a normal option without passing additional argument (like --version ie).

If you may, please, consider reviewing this promptly, 'cause we're using Yacron in kinda production environment and this type of validation is somewhat crucial for our CI/CD pipelines - our devs aren't careful enough to validate configuration on their own.

Thanks in advance.

@gjcarneiro gjcarneiro merged commit 56146b7 into gjcarneiro:master Nov 19, 2021
@gjcarneiro
Copy link
Owner

Heh, sorry for that. I should have paid more attention to the PR that introduced this feature 🙈

@gjcarneiro
Copy link
Owner

v0.15.1 released with the fix; thank you!

@init-penguin
Copy link
Author

Great! Thank you for a quick response!
Maybe i'll come back with some feature requests or contribution in near future ;)

Best wishes to you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants