Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable logging configuration #81

Closed
wants to merge 1 commit into from

Conversation

bdamian
Copy link

@bdamian bdamian commented Feb 9, 2023

Hi there!

I've added an option to customize logs produced by yacron. I've also wrote a note about it in README.

Motivation for the change was to find out when tasks has failed. I'm aware of the sentry integration though sometimes much simpler text file logs is enough.

@gjcarneiro
Copy link
Owner

To be honest, I would prefer to have this logging configuration as part of the main yacron config file. Why split this into two config files?

@gjcarneiro
Copy link
Owner

Hi, I started work on #83 that will likely replace this PR. But thanks for this work! I used your idea and some of your code, but it has a different approach: I think it's a better user experience to have all configuration in a single place, instead of scattered.

@bdamian
Copy link
Author

bdamian commented Mar 10, 2023

Thanks for your interest!
For me it's no difference where the extra config for logging would be. So I would follow PR #83

@gjcarneiro
Copy link
Owner

Closing in favour of #83.

@gjcarneiro gjcarneiro closed this Mar 11, 2023
@DheerajKhajuria
Copy link

Does it support logging to file using handler?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants