Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ipywidgets and scipy properly optional #100

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

gjoseph92
Copy link
Owner

Typo on ipywidgets was causing the whole jupyter stack to get installed for the base stackstac installation!

Scipy is only needed for reproject_array, which isn't in the core API IMO. And xarray already raises a decent error when it's missing.

Typo on `ipywidgets` was causing the whole jupyter stack to get installed for the base stackstac installation!

Scipy is only needed for `reproject_array`, which isn't in the core API IMO. And xarray already raises a decent error when it's missing.
@gjoseph92 gjoseph92 merged commit d3a78c4 into main Dec 3, 2021
@gjoseph92 gjoseph92 deleted the optional-ipywidgets-scipy branch December 3, 2021 19:35
@gjoseph92 gjoseph92 added the needs-future-test Add a test for this in the future, once tests exist (#26) label Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-future-test Add a test for this in the future, once tests exist (#26)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant