Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherit @tsconfig/strictest #29

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Inherit @tsconfig/strictest #29

merged 2 commits into from
Mar 29, 2024

Conversation

swsnr
Copy link
Collaborator

@swsnr swsnr commented Mar 29, 2024

Follow up to #28 I'd suggest to inherit from the recommended strictest typescript configuration, to make sure that these type declarations are as consistent as we can get.

@swsnr
Copy link
Collaborator Author

swsnr commented Mar 29, 2024

I've also added a commit which bumps the action versions to fix a deprecation warning in CI.

@Totto16 Totto16 self-assigned this Mar 29, 2024
Copy link
Collaborator

@Totto16 Totto16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these changes ❤️

@Totto16 Totto16 merged commit 77a185b into gjsify:main Mar 29, 2024
1 check passed
@swsnr swsnr deleted the tsconfig-strictest branch March 29, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants