Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/quickSettings.d.ts: add constructor props #44

Merged
merged 1 commit into from
May 6, 2024

Conversation

ghost
Copy link

@ghost ghost commented May 6, 2024

Also contains general improvements such as addition of missing types

closes #40

@ghost ghost marked this pull request as draft May 6, 2024 10:45
@ghost ghost marked this pull request as ready for review May 6, 2024 10:53
@ghost ghost force-pushed the ctor-props branch 2 times, most recently from 6aa6b52 to 894b698 Compare May 6, 2024 10:56
Also contains general improvements such as addition of missing types
@Totto16 Totto16 self-assigned this May 6, 2024
Copy link
Collaborator

@Totto16 Totto16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks for your contribution ❤️

@Totto16 Totto16 merged commit 43622f9 into gjsify:main May 6, 2024
1 check passed
@ghost ghost deleted the ctor-props branch May 6, 2024 14:01
@Totto16
Copy link
Collaborator

Totto16 commented May 6, 2024

Since I think, that in the near future nothing will change in this repo, I'll make a release just for this one change, since you probably use those types somewhere

@ghost
Copy link
Author

ghost commented May 6, 2024

since you probably use those types somewhere

I haven't created a single extension, just playing around 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot pass QuickMenuToggle props in constructor/_init
2 participants