-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide 3.2 build support #212
Conversation
Looks like the build passed, but the |
Ta! Just giving that a go now. |
Nice! I'll leave this for @gjtorikian to consider, since there might be aspects of this he has in mind that I'm not aware of, but hopefully this gets us there faster. |
Hm! I've noticed that trying to build this branch on Ruby 3.2.0 with something like this: source "https://rubygems.org"
gem "commonmarker", github: "gjtorikian/commonmarker", branch: "support-32" succeeds on (e.g.) Linux x86_64, but fails on Darwin arm64:
Looks like possibly magnus's preview 3.2.0 support. |
Looks like it might be related to oxidize-rb/rb-sys#88 maybe not triggering as it should? If I repeat the … Actually, It looks like this is to do with RubyGems' own Rust building capabilities running this command for us, which, on further investigation, does actually add this flag these days. Why does my own Ruby 3.2.0's RubyGems not have this, which is part of the |
Yes it should work now. On another note, this thread is worth reading regarding builtin ruby gems cargo builder. Ling story short, using rb_sys as a dependency will yield more predictable results until some issues with Rubygems are addressed with external builders. |
Appreciate you both <3 |
Thanks for the help y'all, this looks great. |
This reverts commit f48eaef.
Should close #211