-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test the new integrated rb-sys #228
Conversation
e862163
to
a7f7aa8
Compare
0.9.63 has been released which officially releases this! |
Heck yeah, thank you! |
a7f7aa8
to
9d18494
Compare
0dc6515
to
a6161ca
Compare
Looks like they already match in your code. So I'm wondering why |
This diff should fix it: diff --git i/commonmarker.gemspec w/commonmarker.gemspec
index a45619e..51b564b 100644
--- i/commonmarker.gemspec
+++ w/commonmarker.gemspec
@@ -17,7 +17,7 @@ Gem::Specification.new do |spec|
# https://github.com/rubygems/rubygems/pull/5852#issuecomment-1231118509
spec.required_rubygems_version = ">= 3.3.22"
- spec.files = ["LICENSE.txt", "README.md", "Cargo.lock"]
+ spec.files = ["LICENSE.txt", "README.md", "Cargo.lock", "Cargo.toml"]
spec.files += Dir.glob("lib/**/*.rb")
spec.files += Dir.glob("ext/**/*.{rs,toml,lock,rb}")
spec.bindir = "exe" |
thanks! |
29bcc48
to
3d14d7a
Compare
5adc2eb
to
a835c75
Compare
76656d4
to
3d0769c
Compare
Commonmarker currently has three different test suites related to the gem build: 1. The compilation output is tested 2. The gem can be installed on another platform 3. A generic version of the gem can be installed on a platform with sufficient Ruby/Rust tooling Of these, only the first is the most relevant. 2 suggests an error in the build pipeline, and 3 opens the door to supporting platforms that are uncommon. In order to minimize support work on my end, I'm going to nix the last two tests; as well, I can abstract the first test into a GitHub Action for other oxidizers to use.
76656d4
to
7fd37da
Compare
BIG 🟥 diff, love it! |
xref oxidize-rb/rb-sys#144