Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an option to merge default configs #315

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

monkeyWzr
Copy link

Fix #314

@gjtorikian
Copy link
Owner

Heya! This looks good, but I'm about to head on vacation and the only change I'd request is for merge_default_options to be removed. You're right in that it's more natural/correct to expect that the rest of one's defaults remain unchanged; so the default here should be to always merge in the defaults (and respect the user's config choice otherwise).

@monkeyWzr
Copy link
Author

Enjoy your vacation!

the only change I'd request is for merge_default_options to be removed

Sure! I'm happy to make the changes but there are two things:

  • tons of tests need to be fixed
  • it might break user's app if someone is relying on the current behavior

For the first one I think I can find a way out. For the second I really don't know what I can do so I'm gonna leave it to you 😄 (maybe some breaking change notes in the changelog?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default options are not fully merged
2 participants