Full support for options and extensions in HtmlRenderer #48
Conversation
kivikakk
changed the title
| @stream = StringIO.new("".force_encoding("utf-8")) | ||
| @need_blocksep = false | ||
| @warnings = Set.new [] | ||
| @in_tight = false | ||
| @in_plain = false | ||
| @buffer = '' | ||
| @tagfilter = extensions.include?(:tagfilter) |
There was a problem hiding this comment.
What's tagfilter? Is that from LIBERAL_HTML_TAG ?
There was a problem hiding this comment.
It's the name of the tagfilter extension as bundled with cmark-gfm; we just detect the name of it here and emulate its behaviour.
lib/commonmarker/renderer.rb
Outdated
| end | ||
|
|
||
| def sourcepos(node) | ||
| if @opts & CommonMarker::Config::Render::SOURCEPOS != 0 |
There was a problem hiding this comment.
Rather than the if indentation I'd rather this bail early:
return "" unless @opts & CommonMarker::Config::Render::SOURCEPOS.zero?
...There was a problem hiding this comment.
👍 That unless example is pretty messed up (logic backwards, missing parens) but I take your point :p
| out('<pre><code') | ||
| if node.fence_info && !node.fence_info.empty? | ||
| out(' class="language-', node.fence_info.split(/\s+/)[0], '">') | ||
| if @opts & CommonMarker::Config::Render::GITHUB_PRE_LANG != 0 |
There was a problem hiding this comment.
Actually now that I see this pattern used a couple of times (one more below!), could we pull it out into a separate method? Like...
def option_included?(option)
@opts & CommonMarker::Config::Render.const_get(option)
end
...
if option_included?(GITHUB_PRE_LANG)
....There was a problem hiding this comment.
const_get gives me the heeby-jeebies but ruby-enum defines a value method which does the same thing.
There was some incomplete support, this is just rounding it off and enabling it on all the same tests we put the normal renderer through.
Most of it doesn't actually need to be switched on or off specially — we rely on the fact that e.g. we'll only get a
strikethroughortable_cellnode if the parser had that enabled in the first place. The only switch we do have which is renderer-specific istagfilter./cc @gjtorikian for review