Remove unnecessary regexp

lib/html_proofer/attribute/url.rb

@@ -221,11 +221,28 @@ def without_hash
         @url.to_s.sub(/##{hash}/, "")
       end
 
-      # catch any obvious issues, like strings in port numbers
+      # catch any obvious issues
       private def clean_url!
-        return if @url =~ /^([!#{Regexp.last_match(0)}-;=?-\[\]_a-z~]|%[0-9a-fA-F]{2})+$/
-
-        @url = Addressable::URI.parse(@url).normalize.to_s
+        parsed_url = Addressable::URI.parse(@url)
+        url = if parsed_url.scheme.nil?
+          parsed_url
+        else
+          normalized_url = parsed_url.normalize
+          if normalized_url.domain&.starts_with?("xn--")
+            normalized_url = normalized_url.display_uri
+          end
+          normalized_url
+        end.to_s
+
+        # normalize strips this off, which causes issues with cache
+        @url = if @url.end_with?("/") && !url.end_with?("/")
+          "#{url}/"
+        elsif !@url.end_with?("/") && url.end_with?("/")
+          url.chop
+        else
+          url
+        end
+      rescue Addressable::URI::InvalidURIError # rubocop:disable Lint/SuppressedException; error will be reported at check time
       end
 
       private def swap_urls!