Remove unnecessary regexp

gjtorikian · May 6, 2024 · 61535f1 · 61535f1
1 parent eecf75d
commit 61535f1
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 4 deletions.
diff --git a/lib/html_proofer/attribute/url.rb b/lib/html_proofer/attribute/url.rb
@@ -221,11 +221,15 @@ def without_hash
         @url.to_s.sub(/##{hash}/, "")
       end
 
-      # catch any obvious issues, like strings in port numbers
+      # catch any obvious issues
       private def clean_url!
-        return if @url =~ /^([!#{Regexp.last_match(0)}-;=?-\[\]_a-z~]|%[0-9a-fA-F]{2})+$/
-
-        @url = Addressable::URI.parse(@url).normalize.to_s
+        parsed_url = Addressable::URI.parse(@url)
+        @url = if parsed_url.scheme.nil?
+          parsed_url
+        else
+          parsed_url.normalize
+        end.to_s
+      rescue Addressable::URI::InvalidURIError # rubocop:disable Lint/SuppressedException; error will be reported at check time
       end
 
       private def swap_urls!

diff --git a/...ixtures/vcr_cassettes/www_github_com_http_/127_0_0_1______log_level_error_type_links_.yml b/...ixtures/vcr_cassettes/www_github_com_http_/127_0_0_1______log_level_error_type_links_.yml