Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple --url-ignore #377

Closed
ilg-ul opened this issue Feb 4, 2017 · 3 comments
Closed

Multiple --url-ignore #377

ilg-ul opened this issue Feb 4, 2017 · 3 comments

Comments

@ilg-ul
Copy link

ilg-ul commented Feb 4, 2017

I noticed that the definition of --url-ignore displayed by --help uses a single option and a comma separated list of URLs.

bundle exec htmlproofer \
  --url-ignore "https://developer.apple.com/xcode/downloads/,http://developer.apple.com/xcode/downloads/" \
  "${site}"

I think it would be useful to also construct the list from multiple options:

bundle exec htmlproofer \
  --url-ignore "https://developer.apple.com/xcode/downloads/" \
  --url-ignore "http://developer.apple.com/xcode/downloads/" \
  "${site}"
@gjtorikian
Copy link
Owner

The problem is that I think the underlying argument parser doesn't support options like that. I believe the parser has the last option "supersede" any of the previous arguments.

If you are aware of a Ruby argument parser that does support both commas as well as multiple --flag options, let me know!

@ilg-ul
Copy link
Author

ilg-ul commented Feb 15, 2017

if you are aware of a Ruby argument parser

Ruby is not really my field of expertise :-(

@fulldecent
Copy link
Collaborator

I have reported this upstream at jekyll/mercenary#49

If this is fixed upstream then we will be able to use the functionality here. Otherwise I do not think we will manually implement that here.

Closing this issue for now we can reopen if that issue is resolved there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants