add whitelisted rel types for indieweb links #528
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #528 +/- ##
==========================================
+ Coverage 98.38% 98.39% +<.01%
==========================================
Files 30 30
Lines 1924 1928 +4
==========================================
+ Hits 1893 1897 +4
Misses 31 31
Continue to review full report at Codecov.
|
gjtorikian
reviewed
Sep 3, 2019
| <head> | ||
| <link rel="me" href="https://github.com/gjtorikian/html-proofer"/> | ||
| <link rel="webmention" href="https://webmention.io/username/webmention" /> | ||
| <link rel="pingback" href="https://webmention.io/username/xmlrpc" /> |
|
Preferring #529 over this since it better matches the specification, which is a whitelist. |
|
I trust @fulldecent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various indieweb capabilities use
linktags, withrels likeme,webmentionandpingback. Those don't need SRI or CORS, so this PR whitelists them.I think there's a better approach to this using a blacklist of rel types rather than a whitelist - after all, the browser will only load certain types. I'll put together another PR for that (update, it's #529), but I wanted to get this simple fix in first in case that one proves more contentious.
If #529 is the preferred solution, this can either be binned or I can update it to just include the new test.