Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor code to es module #336

Merged
merged 31 commits into from
Jul 30, 2024
Merged

chore: refactor code to es module #336

merged 31 commits into from
Jul 30, 2024

Conversation

gka
Copy link
Owner

@gka gka commented Jul 9, 2024

trying to bring chroma into 2024...

TODOS:

  • refactor code to ES6 modules
  • update package.json
  • switch to pnpm
  • upgrade eslint
  • setup prettier for code formatting
  • update husky script to ensure tests are run on commit
  • move bundles to dist/
  • refactor tests to vitest (29 done, 20 remaining)
  • bump version

@gka
Copy link
Owner Author

gka commented Jul 28, 2024

@zyyv (or anyone else) in case you want to help, feel free to take care of converting some more of the test files from Vows to Vitest. I've been using ChatGPT for this (asking to convert tests from Vows.js to Vitest) and it's been working quite good so far, although it's not 100% perfect.

Here's my prompt

Can you convert the following Vows.js unit test to Vitest? You don't need to include the Vows test in your output and can also omit the Vitest setup instructions.

TEST HERE

@gka gka added the dependencies Pull requests that update a dependency file label Jul 28, 2024
@zyyv
Copy link
Collaborator

zyyv commented Jul 29, 2024

I'd be happy to help with the test migration refactoring, and I'll check the remaining test cases in my free time.

@zyyv zyyv mentioned this pull request Jul 30, 2024
@origami-z
Copy link

This change caused a bunch of downstream problems, and should happen in a breaking major change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants