Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steps query parameter resets to 7 #2

Open
basham opened this issue Mar 1, 2015 · 1 comment · May be fixed by #3
Open

Steps query parameter resets to 7 #2

basham opened this issue Mar 1, 2015 · 1 comment · May be fixed by #3

Comments

@basham
Copy link

basham commented Mar 1, 2015

When manually setting the steps query parameter:

http://gka.github.io/palettes/#colors=lightyellow,orange,deeppink,darkred|steps=11|bez=1|coL=1

The steps query parameter automatically updates to 7:

http://gka.github.io/palettes/#colors=lightyellow,orange,deeppink,darkred|steps=7|bez=1|coL=1

The provided step query parameter should be retained and applied. All other query parameters (i.e. colors, bez, and coL) work as expected.

@basham basham changed the title Steps query parameter resets to 7 Steps query parameter resets to 7 Mar 1, 2015
@basham
Copy link
Author

basham commented Mar 1, 2015

It seems to work as expected with diverging URLs. Just not sequential URLs.

http://gka.github.io/palettes/#diverging|c0=lightyellow,orange,deeppink,darkred|c1=lightyellow,orange,deeppink,darkred|steps=15|bez0=1|bez1=1|coL0=1|coL1=1

frederfred added a commit to frederfred/palettes that referenced this issue Jan 22, 2019
When visiting https://gka.github.io/palettes/#colors=#000,#f0f,#fff|steps=21|bez=0|coL=0 , "Step count" is immediately set to 7 and not picked up by the url. This PR fixes this issue.

Resolves gka#2
@frederfred frederfred linked a pull request Jan 22, 2019 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant