Bugfix: Let axc_context_destroy_all() free ctx passed to it. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The project is using axc (e.g. lurch) assumes axc_context_destroy_all() will free the ctx passed to it, but axc_context_destroy_all() actually only cleans up its members, without freeing itself, which will cause severe memory leak. Signed-off-by: HardenedVault <root@hardenedvault.net>
|
good find, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project is using axc (e.g. lurch) assumes axc_context_destroy_all()
will free the ctx passed to it, but axc_context_destroy_all() actually only
cleans up its members, without freeing itself, which will cause severe memory
leak.
Signed-off-by: HardenedVault root@hardenedvault.net