Added option to ignore bad json files when reading the jsondir #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,9 +22,12 @@ var collectJSONS = function(options) { | |||
| jsonOutput.push(json); | |||
| } | |||
|
|
|||
| if (!cucumberJson || typeof cucumberJson[0] === 'undefined') { | |||
| if (!cucumberJson || typeof cucumberJson[0] === 'undefined' && !options.ignoreBadJsonFile) { | |||
There was a problem hiding this comment.
Can you add parenthesis to the both if & else conditions?
if ((!cucumberJson || typeof cucumberJson[0] === 'undefined') && !options.ignoreBadJsonFile)
Because it will throw Error even if options.ignoreBadJsonFile = false but if cucumberJson isn't valid object.
|
Looks good apart from minor comment. I will merge this once it's resolved. Thanks @thyagab for adding the option! |
|
@gkushang thank you for accepting the PR and for review comments. fixed and checked in. |
|
@thyagab published the change as |
|
Thank you @gkushang |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option to ignore any bad json files to merge. This will help to ignore any empty json files getting created by protractor process for feature files with no scenarios to execute.
var options = {
theme: 'bootstrap',
jsonFile: 'test/report/cucumber_report.json',
output: 'test/report/cucumber_report.html',
reportSuiteAsScenarios: true,
launchReport: true,
ignoreBadJsonFile:true
};