Pass meshShader attributes manually (shoutout to @dy) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this fixes issues reported in #4 (comment) that seem to only appear on etpinard's thinkpad running Ubuntu 16.04
etpinard
commented
May 15, 2018
| @@ -1,17 +1,18 @@ | |||
| "use strict"; | |||
|
|
|||
| const V = require('gl-vec3'); | |||
| const V4 = require('gl-vec4'); | |||
| var V = require('gl-vec3'); | |||
There was a problem hiding this comment.
cc @kig plotly.js src code must be es5 compliant.
You can use an es6->es5 browserify transform if you prefer in your other gl-vis modules.
There was a problem hiding this comment.
Right, I'll port them over from es6-style. There shouldn't be much to change, just const, let, some deconstructors and object constructors.
... that plotly.js can set cmin and cmax
|
Looks good to me. One nit with indent width changing, I'll fix on my end |
etpinard
added a commit
to gl-vis/gl-streamtube3d
that referenced
this pull request
May 23, 2018
- this is the same fix as in gl-vis/gl-cone3d#5 to make gl-streamtubes3d work on etpinard's thinkpad running Ubuntu 16.04.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cones are stretched out when axis spans don't match #4 (comment)
that seem to only appear on etpinard's thinkpad running
Ubuntu 16.04
@dy believes this is an issue with gl-shader. Perhaps we should investigate further.
cc @kig