Add support for min_id pagination parameter #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for all these PRs, I'm gonna loot at them 👍 |
glacasa
reviewed
Jun 18, 2019
|
|
||
| You can always let the `limit` to its default value or define the number of items you want to load. | ||
|
|
||
| All the methods can be called with the 3 params `maxId`, `sinceId`, and `limit`, or using an `ArrayOptions` object. The result will be the same. Only the methods with `ArrayOptions` are presented below. | ||
| Note that the 3-parameter overloads don't have `minId` for backward compatibility. Use the overloads with `ArrayOptions` if you need it. |
There was a problem hiding this comment.
Do you think we should mark those 3-parameters methods obsolete in a future (major) release ?
There was a problem hiding this comment.
I think so. They can be easily rewritten to use ArrayOptions and their advantage is just a little convenience. Furthermore, if min_id is present, the other id parameters seem to be ignored (mastodon/mastodon#8736), so arbitrarily specifyable parameters can be misleading to users. Class can handle it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#39.