chore: apply suggestions from code review

Co-authored-by: Jakob Steiner <kosmoz@users.noreply.github.com>
glasskube · Jan 15, 2025 · 4ecaa46 · 4ecaa46
1 parent 1b59f23
commit 4ecaa46
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/frontend/cloud-ui/src/app/components/installation-wizard/installation-wizard.component.ts b/frontend/cloud-ui/src/app/components/installation-wizard/installation-wizard.component.ts
@@ -13,7 +13,7 @@ import {DeploymentTargetsService} from '../../services/deployment-targets.servic
 import {DeploymentService} from '../../services/deployment.service';
 import {ToastService} from '../../services/toast.service';
 import {Application} from '../../types/application';
-import {Deployment, DeploymentRequest, DeploymentType} from '../../types/deployment';
+import {DeploymentRequest, DeploymentType} from '../../types/deployment';
 import {DeploymentTarget} from '../../types/deployment-target';
 import {InstallationWizardStepperComponent} from './installation-wizard-stepper.component';
 import {getFormDisplayedError} from '../../../util/errors';

diff --git a/frontend/cloud-ui/src/app/components/onboarding-wizard/onboarding-wizard.component.ts b/frontend/cloud-ui/src/app/components/onboarding-wizard/onboarding-wizard.component.ts
@@ -11,7 +11,7 @@ import {DeploymentTargetsService} from '../../services/deployment-targets.servic
 import {DeploymentService} from '../../services/deployment.service';
 import {CreateUserAccountRequest, UsersService} from '../../services/users.service';
 import {Application, ApplicationVersion} from '../../types/application';
-import {Deployment, DeploymentRequest, DeploymentType, HelmChartType} from '../../types/deployment';
+import {DeploymentRequest, DeploymentType, HelmChartType} from '../../types/deployment';
 import {DeploymentTarget} from '../../types/deployment-target';
 import {ConnectInstructionsComponent} from '../connect-instructions/connect-instructions.component';
 import {OnboardingWizardIntroComponent} from './intro/onboarding-wizard-intro.component';

diff --git a/frontend/cloud-ui/src/app/deployments/deployment-targets.component.ts b/frontend/cloud-ui/src/app/deployments/deployment-targets.component.ts
@@ -55,7 +55,7 @@ import {DeploymentService} from '../services/deployment.service';
 import {DialogRef, OverlayService} from '../services/overlay.service';
 import {ToastService} from '../services/toast.service';
 import {Application} from '../types/application';
-import {Deployment, DeploymentRequest, DeploymentStatus, DeploymentType} from '../types/deployment';
+import {DeploymentRequest, DeploymentStatus, DeploymentType} from '../types/deployment';
 import {DeploymentTarget} from '../types/deployment-target';
 import {getFormDisplayedError} from '../../util/errors';
 

diff --git a/internal/types/data.go b/internal/types/data.go
@@ -102,14 +102,14 @@ type OrganizationBranding struct {
 type Deployment struct {
 	Base
 	DeploymentTargetId string  `db:"deployment_target_id" json:"deploymentTargetId"`
-	ReleaseName        *string `db:"release_name" json:"releaseName"`
+	ReleaseName        *string `db:"release_name" json:"releaseName,omitempty"`
 }
 
 type DeploymentRevision struct {
 	Base
 	DeploymentID         string `db:"deployment_id" json:"deploymentId"`
 	ApplicationVersionId string `db:"application_version_id" json:"applicationVersionId"`
-	ValuesYaml           []byte `db:"-" json:"valuesYaml"`
+	ValuesYaml           []byte `db:"-" json:"valuesYaml,omitempty"`
 }
 
 type DeploymentWithLatestRevision struct {
@@ -119,7 +119,7 @@ type DeploymentWithLatestRevision struct {
 	ApplicationName        string `db:"application_name" json:"applicationName"`
 	ApplicationVersionId   string `db:"application_version_id" json:"applicationVersionId"`
 	ApplicationVersionName string `db:"application_version_name" json:"applicationVersionName"`
-	ValuesYaml             []byte `db:"values_yaml" json:"valuesYaml"`
+	ValuesYaml             []byte `db:"values_yaml" json:"valuesYaml,omitempty"`
 }
 
 func (d DeploymentWithLatestRevision) ParsedValuesFile() (result map[string]any, err error) {