feat: organization branding #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philip Miglinci <pmig@glasskube.com>
frontend/cloud-ui/src/app/organization-branding/organization-branding.component.ts
Show resolved
Hide resolved
frontend/cloud-ui/src/app/organization-branding/organization-branding.component.ts
Show resolved
Hide resolved
frontend/cloud-ui/src/app/organization-branding/organization-branding.component.html
Outdated
Show resolved
Hide resolved
frontend/cloud-ui/src/app/organization-branding/organization-branding.component.html
Outdated
Show resolved
Hide resolved
frontend/cloud-ui/src/app/organization-branding/organization-branding.component.ts
Show resolved
Hide resolved
frontend/cloud-ui/src/app/organization-branding/organization-branding.component.html
Outdated
Show resolved
Hide resolved
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
| func OrganizationBrandingRouter(r chi.Router) { | ||
| r.Get("/", getOrganizationBranding) | ||
| r.With(requireUserRoleVendor).Group(func(r chi.Router) { | ||
| r.Post("/", createOrganizationBranding) |
There was a problem hiding this comment.
on another note, we could have simply done only one PUT request, because PUT means both create or update, and by reading the path variable (branding id) we could decide whether to do a database insert or update. Because the two endpoints are the same code except for the db call.
There was a problem hiding this comment.
- as long as a user can only be in one organization (which will of course change), there is no need for the branding ID in the path, it can only ever be the branding object of the current organization (which is in the token)
kosmoz
reviewed
Jan 14, 2025
frontend/cloud-ui/src/app/components/nav-bar/nav-bar.component.ts
Outdated
Show resolved
Hide resolved
frontend/cloud-ui/src/app/services/organization-branding.service.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Jakob Steiner <kosmoz@users.noreply.github.com>
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
…randing.component.html Co-authored-by: Jakob Steiner <kosmoz@users.noreply.github.com>
Signed-off-by: Philip Miglinci <pmig@glasskube.com>
Signed-off-by: Philip Miglinci <pmig@glasskube.com>
Signed-off-by: Philip Miglinci <pmig@glasskube.com>
christophenne
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.