Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add selecting a license for a deployment #463

Merged
merged 18 commits into from
Feb 18, 2025
Merged

feat: add selecting a license for a deployment #463

merged 18 commits into from
Feb 18, 2025

Conversation

kosmoz
Copy link
Member

@kosmoz kosmoz commented Feb 11, 2025

No description provided.

christophenne
christophenne reviewed Feb 17, 2025
View reviewed changes
Copy link
Member

@christophenne christophenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge improvement on the forms 👍 here some preliminary feedback

kosmoz added 14 commits February 18, 2025 15:13
@kosmoz
feat: select license for deployment [WIP]
5c1fe6a
@kosmoz
chore: refactor deployment form
e209315 
Signed-off-by: Jakob Steiner <jakob.steiner@glasskube.eu>
@kosmoz
chore: fix some bugs and implement license ID in PUT endpoint
03023e3 
Signed-off-by: Jakob Steiner <jakob.steiner@glasskube.eu>
@kosmoz
chore: show version from application if empty in license
693131e 
Signed-off-by: Jakob Steiner <jakob.steiner@glasskube.eu>
@kosmoz
refactor(backend): refactor putDeployment handler
ecc7979
@kosmoz
chore(ui): use real licenses service
7b2acaa
@kosmoz
fix(frontend): avoid unnecessary requests
c384aec
@kosmoz
fix: various fixes…
290b3f9
@kosmoz
fix: avoid unwanted license control reset
b94a35a
@kosmoz
fix: handle form control on touched
2b96e9f
@kosmoz
chore: remove redundant valid check
a5a8d6e
@kosmoz
fix(backend): allow deployment update
f75b28a
@kosmoz
fix(ui): do not overwrite license ID
49e6ba3
@kosmoz
chore: fixes after rebase
45c75de 
Signed-off-by: Jakob Steiner <jakob.steiner@glasskube.eu>
@kosmoz kosmoz force-pushed the kosmoz/gk-524-assigning-an-application-license-to-a-deploymenttarget branch from 47f5070 to 45c75de Compare February 18, 2025 14:17
@kosmoz
chore: remove get application versions endpoint
309d8b3 
Signed-off-by: Jakob Steiner <jakob.steiner@glasskube.eu>
@kosmoz
Merge remote-tracking branch 'origin/main' into kosmoz/gk-524-assigni…
31bb15b 
…ng-an-application-license-to-a-deploymenttarget
@kosmoz kosmoz requested a review from christophenne February 18, 2025 14:19
@kosmoz kosmoz marked this pull request as ready for review February 18, 2025 14:19
kosmoz and others added 2 commits February 18, 2025 15:41
@kosmoz @christophenne
Update frontend/ui/src/app/deployment-form/deployment-form.component.ts
05850eb 
Co-authored-by: Christoph Enne <christoph.enne@glasskube.eu>
@kosmoz
chore: remove unused interface
db73a93 
Signed-off-by: Jakob Steiner <jakob.steiner@glasskube.eu>
@kosmoz kosmoz requested a review from christophenne February 18, 2025 14:42
@kosmoz kosmoz merged commit f68aeee into main Feb 18, 2025
10 checks passed
@kosmoz kosmoz deleted the kosmoz/gk-524-assigning-an-application-license-to-a-deploymenttarget branch February 18, 2025 14:53
@glasskube-bot glasskube-bot mentioned this pull request Feb 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophenne christophenne christophenne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kosmoz @christophenne