Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: application version archive #520

Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open

feat: application version archive #520

wants to merge 38 commits into from

Conversation

christophenne
Copy link
Member

No description provided.

@christophenne
feat: application detail page WIP
eb5764b 
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
@christophenne
feat: application dropdown in breadcrumb
6ffaa22 
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
@christophenne
feat: application version archive
f6d0b12 
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
@christophenne
Merge branch 'main' into christophenne/gk-516-make-it-possible-to-arc…
23f9292 
…hive-application-versions
@christophenne
fix: query with archived_at
b3a3e0f 
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
@christophenne
Merge branch 'main' into christophenne/gk-516-make-it-possible-to-arc…
a9ba4f2 
…hive-application-versions
@christophenne
chore: const for duplicated application selects
8044bf9 
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
@christophenne
Merge branch 'main' into christophenne/gk-516-make-it-possible-to-arc…
0aa8805 
…hive-application-versions
@christophenne
chore: edit router link
c4e8eb4 
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
@christophenne
fix: add application id in version object
79b3b2d 
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
@christophenne
Merge branch 'main' into christophenne/gk-516-make-it-possible-to-arc…
1c929b4 
…hive-application-versions
@christophenne
fix: archived_at and application_id in license response
9ae825c 
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
@christophenne
feat: inline edit application name
95644da 
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
@christophenne
fix: inline edit application name
9b87c78 
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
@christophenne
chore: update actions in application table
f50fe05 
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
@christophenne
chore(ui): only show non-archived versions
920013c 
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
@christophenne
chore(ui): create application in modal
722ab0a 
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
@christophenne
chore(ui): move app delete to detail page
132f504 
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
@christophenne
feat: archive implementation
aa0f6e4 
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
@christophenne
chore: don't override archived_at
b86e841 
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
@christophenne
fix: version creation form reset
0c521c1 
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
@christophenne
fix: make unarchive possible
fc65760 
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
@christophenne
feat: filter to include archived items
eda2c35 
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
@christophenne
fix: version sorting
8bbcc2b 
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
@christophenne
fix: breadcrumb dropdown style
821c0c3 
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
@christophenne christophenne marked this pull request as ready for review February 20, 2025 11:50
@christophenne christophenne requested a review from kosmoz February 20, 2025 11:50
kosmoz
kosmoz requested changes Feb 20, 2025
View reviewed changes
Copy link
Member

@kosmoz kosmoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the new page, and it makes the applications component a lot smaller too, which is nice.

One more piece of feedback from my side would be that it is no longer obvious from the table how to add/view versions. So maybe The button label could be changed to "Details/Edit" or something like that?

@christophenne
Merge branch 'main' into christophenne/gk-516-make-it-possible-to-arc…
8cd344d 
…hive-application-versions
@christophenne
chore: bump migration version
84fab90 
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
christophenne and others added 8 commits February 21, 2025 12:05
@christophenne
Merge branch 'main' into christophenne/gk-516-make-it-possible-to-arc…
eb35d68 
…hive-application-versions

# Conflicts:
#	internal/db/applications.go
@christophenne
chore: fix bumping migration version
b903778 
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
@christophenne
fix(backend): archived_at flag not returned everywhere
2e3f941 
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
@christophenne
chore(ui): change application row label
f00b3c1 
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
@christophenne @kosmoz
chore: apply suggestions from code review
5afea94 
Co-authored-by: Jakob Steiner <kosmoz@users.noreply.github.com>
@christophenne @kosmoz
Update frontend/ui/src/app/applications/application-detail.component.…
0cbd122 
…html

Co-authored-by: Jakob Steiner <kosmoz@users.noreply.github.com>
@christophenne
chore(ui): minor cleanup
800a73d 
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
@christophenne
chore(ui): improve routes
52a5628 
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
@christophenne christophenne requested a review from kosmoz February 21, 2025 11:27
@christophenne
chore(ui): remove shadow in new app modal
461f8fe 
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
@christophenne
chore(ui): fix edit button in light mode
1e2642f 
Signed-off-by: christophenne <christoph.enne@glasskube.eu>
@christophenne christophenne mentioned this pull request Feb 21, 2025
Draft
@christophenne @kosmoz
Update frontend/ui/src/app/app.routes.ts
4662610 
Co-authored-by: Jakob Steiner <kosmoz@users.noreply.github.com>
kosmoz
kosmoz approved these changes Feb 21, 2025
View reviewed changes
Copy link
Member

@kosmoz kosmoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing I noticed (but didn't include in the last review) is that the click area of the breadcrumb dropdown is smaller than the area highlighted on hover. IMO not blocking but if it's an easy fix we might as well …

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kosmoz kosmoz kosmoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christophenne @kosmoz