Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Provide more options for Gitlab Registry storage configuration #447

Closed
1 task done
christophenne opened this issue Dec 7, 2023 · 0 comments · Fixed by #448
Closed
1 task done

[Feature]: Provide more options for Gitlab Registry storage configuration #447

christophenne opened this issue Dec 7, 2023 · 0 comments · Fixed by #448
Assignees
@christophenne
Labels
apps/gitlab enhancement New feature or request

Comments

@christophenne
Copy link
Member

Checklist

  • I've searched for similar issues and couldn't find anything matching

Is this feature request related to a problem?

None

Problem Description

In the Gitlab CRD, hostname and usePathStyle are required, and there is no option to configure the port or whether to use SSL or not.

Solution Description

Make the hostname and usePathStyle (default false) optional and add fields port and useSsl.

Benefits

  • Custom S3 providers can be configured in more detail.
  • AWS S3 buckets can be configured easier.

Potential Drawbacks

No response

Additional Information

No response
@christophenne christophenne self-assigned this Dec 7, 2023
christophenne added a commit that referenced this issue Dec 7, 2023
@christophenne
feature(Gitlab): provide more options for registry storage configurat…
e27d13d 
…ion (#447)
christophenne added a commit that referenced this issue Dec 7, 2023
@christophenne
feat(Gitlab): provide more options for registry storage configuration (…
b885e18 
…#447)
@christophenne christophenne mentioned this issue Dec 7, 2023
Merged
@christophenne christophenne linked a pull request Dec 7, 2023 that will close this issue
feat(Gitlab): provide more options for registry storage configuration (#447) #448
Merged
@christophenne christophenne added apps/gitlab enhancement New feature or request labels Dec 7, 2023
christophenne added a commit that referenced this issue Dec 7, 2023
@christophenne
feat(Gitlab): provide more options for registry storage configuration (…
20c1fda 
…#447)
christophenne added a commit that referenced this issue Dec 7, 2023
@christophenne
feat(Gitlab): provide more options for registry storage configuration (…
a74bc6e 
…#447)
christophenne added a commit that referenced this issue Dec 7, 2023
@christophenne
feat(Gitlab): provide more options for registry storage configuration (…
6230f30 
…#447)
christophenne added a commit that referenced this issue Dec 13, 2023
@christophenne
feat(Gitlab): provide more options for registry storage configuration (…
1610541 
…#447)
christophenne added a commit that referenced this issue Dec 13, 2023
@christophenne
feat(Gitlab): provide more options for registry storage configuration (…
cef6d20 
…#447)
@pmig pmig closed this as completed in #448 Dec 13, 2023
pmig pushed a commit that referenced this issue Dec 13, 2023
@christophenne @pmig
feat(Gitlab): provide more options for registry storage configuration (…
1bf0622 
…#447)
@christophenne christophenne mentioned this issue Dec 22, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christophenne christophenne

Labels
apps/gitlab enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(Gitlab): provide more options for registry storage configuration (#447) glasskube/operator
1 participant
@christophenne