Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: first version of helm chart #126

Merged
merged 6 commits into from
Jun 30, 2023
Merged

Conversation

thschue
Copy link
Collaborator

@thschue thschue commented May 15, 2023

This PR

  • Adds the first version of a helm chart
  • Adds simple workflow to release the chart

@thschue thschue marked this pull request as ready for review May 16, 2023 06:04
Copy link
Member

@kosmoz kosmoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally the chart works great! 🎉

I did find some issues though, which we should address.

Also, the CRDs are currently auto-generated and placed in the deploy directory by a gradle task. We should probably do something similar for the chart, however I think it's okay if that's done in a follow-up ticket.

charts/glasskube-operator/values.yaml Outdated Show resolved Hide resolved
charts/glasskube-operator/templates/deploy.yaml Outdated Show resolved Hide resolved
charts/glasskube-operator/templates/namespace.yaml Outdated Show resolved Hide resolved
charts/glasskube-operator/Chart.yaml Show resolved Hide resolved
charts/glasskube-operator/templates/serviceAccount.yaml Outdated Show resolved Hide resolved
@thschue thschue requested a review from kosmoz May 17, 2023 06:09
@thschue
Copy link
Collaborator Author

thschue commented May 17, 2023

Thank you for your review! I addressed the comments, I'd propose that we do the auto-generation of CRDs in a second issue.

Copy link
Member

@kosmoz kosmoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried the chart again and it works now. 🎉

If you could implement the following changes, we would be ready to merge this PR:

  • After some discussion, we decided that we would prefer to rename the values identifier glasskubeOperator to operator.
  • Some time has passed since this PR was created (this is our bad…), so it is necessary to add the missing CRDs and update the RBAC manifest.
  • We decided to keep the dependencies as part of the chart, but they should be disabled by default. This means that for each dependency there should be a condition in the Chart.yaml and its default value in values.yaml should be set to false.
  • The appVersion can be updated to 0.5.2.
  • The MariaDB Operator version can be updated to 0.15.1, which the latest version of our operator should be compatible with.

Signed-off-by: Thomas Schuetz <thomas.schuetz@whizus.com>
Signed-off-by: Thomas Schuetz <thomas.schuetz@whizus.com>
Signed-off-by: Thomas Schuetz <thomas.schuetz@whizus.com>
Signed-off-by: Thomas Schuetz <thomas.schuetz@whizus.com>
Signed-off-by: Thomas Schuetz <thomas.schuetz@whizus.com>
Signed-off-by: Thomas Schuetz <thomas.schuetz@whizus.com>
@kosmoz kosmoz merged commit 1188bbf into glasskube:main Jun 30, 2023
1 check passed
@pmig pmig mentioned this pull request Jul 14, 2023
@pmig pmig linked an issue Jul 14, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm Chart
2 participants