-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: first version of helm chart #126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally the chart works great! 🎉
I did find some issues though, which we should address.
Also, the CRDs are currently auto-generated and placed in the deploy directory by a gradle task. We should probably do something similar for the chart, however I think it's okay if that's done in a follow-up ticket.
Thank you for your review! I addressed the comments, I'd propose that we do the auto-generation of CRDs in a second issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried the chart again and it works now. 🎉
If you could implement the following changes, we would be ready to merge this PR:
- After some discussion, we decided that we would prefer to rename the values identifier
glasskubeOperator
tooperator
. - Some time has passed since this PR was created (this is our bad…), so it is necessary to add the missing CRDs and update the RBAC manifest.
- We decided to keep the dependencies as part of the chart, but they should be disabled by default. This means that for each dependency there should be a
condition
in theChart.yaml
and its default value invalues.yaml
should be set tofalse
. - The
appVersion
can be updated to0.5.2
. - The MariaDB Operator version can be updated to
0.15.1
, which the latest version of our operator should be compatible with.
Signed-off-by: Thomas Schuetz <thomas.schuetz@whizus.com>
Signed-off-by: Thomas Schuetz <thomas.schuetz@whizus.com>
Signed-off-by: Thomas Schuetz <thomas.schuetz@whizus.com>
Signed-off-by: Thomas Schuetz <thomas.schuetz@whizus.com>
Signed-off-by: Thomas Schuetz <thomas.schuetz@whizus.com>
Signed-off-by: Thomas Schuetz <thomas.schuetz@whizus.com>
This PR