feat(Gitea): add CRD property to toggle SSH Service creation (#137) #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmig
requested changes
May 30, 2023
There was a problem hiding this comment.
Migration works fine, also LoadBalancer is correctly reconciled based on feature flag.
In order to improve UX we should also enable / disable the ssh clone link in the UI via the env variable DISABLE_SSH
pmig
force-pushed
the
137-disable-ssh-support-for-gitea
branch
from
24611a5
to
d00eda8
Compare
Signed-off-by: Philip Miglinci <pmig@glasskube.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.