Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Metabase): add Metabase 0.46.5 (#134) #168

Merged
merged 7 commits into from
Jun 26, 2023
Merged

feat(Metabase): add Metabase 0.46.5 (#134) #168

merged 7 commits into from
Jun 26, 2023

Conversation

pmig
Copy link
Member

@pmig pmig commented Jun 21, 2023 •
edited
Loading

resolves #134

@pmig pmig requested a review from kosmoz June 22, 2023 10:24
@kosmoz kosmoz marked this pull request as ready for review June 22, 2023 11:27
kosmoz
kosmoz requested changes Jun 26, 2023
View reviewed changes
Copy link
Member

@kosmoz kosmoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all seems to work well.

Here are some issues that we should address though.

operator/src/main/kotlin/eu/glasskube/operator/apps/metabase/dependent/MetabaseDeployment.kt Outdated Show resolved Hide resolved
operator/src/main/kotlin/eu/glasskube/operator/apps/metabase/dependent/MetabaseHttpService.kt Outdated Show resolved Hide resolved
operator/src/main/kotlin/eu/glasskube/operator/apps/metabase/dependent/MetabaseHttpService.kt Outdated Show resolved Hide resolved
...tor/src/main/kotlin/eu/glasskube/operator/apps/metabase/dependent/MetabasePostgresCluster.kt Show resolved Hide resolved
pmig added 4 commits June 26, 2023 15:24
@pmig
feat(Metabase): add Metabase 0.46.5 (#134)
ae0d52c 
Signed-off-by: Philip Miglinci <pmig@glasskube.eu>
@pmig
feat(Metabase): add email configuration (#134)
05e7198 
Signed-off-by: Philip Miglinci <pmig@glasskube.eu>
@pmig
feat(Metabase): add encryption secret key (#134)
a73f399 
Signed-off-by: Philip Miglinci <pmig@glasskube.eu>
@pmig
chore(Metabase): remove unused discriminator (#134)
dd91784 
Signed-off-by: Philip Miglinci <pmig@glasskube.eu>
@kosmoz
Copy link
Member

kosmoz commented Jun 26, 2023

Also, please add a resource requirements property to the spec class, as this should be done for all CRDs now.

pmig added 2 commits June 26, 2023 15:27
@pmig
chore(Metabase): fix ready post condidition and refactor http service
a109437 
Signed-off-by: Philip Miglinci <pmig@glasskube.eu>
@pmig
feat(Metabase): support resources limits
c7db7b1 
Signed-off-by: Philip Miglinci <pmig@glasskube.eu>
@pmig pmig requested a review from kosmoz June 26, 2023 13:44
@kosmoz kosmoz merged commit a31b007 into main Jun 26, 2023
@kosmoz kosmoz deleted the 134_metabase branch June 26, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kosmoz kosmoz kosmoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metabase Support
2 participants
@pmig @kosmoz