Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Nextcloud): add Nextcloud #193

Merged
merged 8 commits into from
Jul 11, 2023
Merged

feat(Nextcloud): add Nextcloud #193

merged 8 commits into from
Jul 11, 2023

Conversation

kosmoz
Copy link
Member

@kosmoz kosmoz commented Jul 4, 2023

No description provided.

@kosmoz kosmoz self-assigned this Jul 4, 2023
@kosmoz kosmoz linked an issue Jul 4, 2023 that may be closed by this pull request
@kosmoz kosmoz marked this pull request as ready for review July 5, 2023 10:21
@kosmoz kosmoz requested a review from pmig July 5, 2023 10:21
Copy link
Member

@pmig pmig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything worked will trying it the first time :-).

I especially like the generic RedisNameMapper and PostgresReadyCondition.

As we currently never limit cpu, I'm not 100% sure why it would make sense in this case.

From a product point of view the NextCloud installation will benefit from an option of using an s3 bucket as file storage. I Think that we should add this feature as it will also make sense for our own usage.

@kosmoz kosmoz requested a review from pmig July 7, 2023 11:54
pmig added 4 commits July 11, 2023 14:41
Signed-off-by: Philip Miglinci <pmig@glasskube.eu>
Signed-off-by: Philip Miglinci <pmig@glasskube.eu>
Signed-off-by: Philip Miglinci <pmig@glasskube.eu>
Signed-off-by: Philip Miglinci <pmig@glasskube.eu>
@pmig pmig changed the title feat(Nextcloud): add CRD and initial resources feat(Nextcloud): add Nextcloud Jul 11, 2023
Signed-off-by: Philip Miglinci <pmig@glasskube.eu>
@pmig pmig merged commit 42b39b5 into main Jul 11, 2023
1 check passed
@pmig pmig deleted the 160-nextcloud-support branch July 11, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nextcloud Support
2 participants