feat(Vault): add initial support (#162) #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kosmoz
changed the title
kosmoz
force-pushed
the
162-hasicorp-vault-support
branch
from
6402f40
to
4525faf
Compare
kosmoz
force-pushed
the
162-hasicorp-vault-support
branch
from
4525faf
to
80770db
Compare
kosmoz
force-pushed
the
162-hasicorp-vault-support
branch
from
80770db
to
50da2b9
Compare
pmig
reviewed
Jul 27, 2023
There was a problem hiding this comment.
Vault installation works like a charm. Super nice expirience. Following minor improvements will improve stability:
run-with-auth.shshould cancel execution if the first request fails- A (Cluster-)
RoleBindingfor theServiceAccountis missing if transit unseal is enabled
kosmoz
force-pushed
the
162-hasicorp-vault-support
branch
from
bf36f46
to
3d23c3a
Compare
kosmoz
force-pushed
the
162-hasicorp-vault-support
branch
from
3d23c3a
to
359f2b6
Compare
pmig
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.