Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add specifying app version in crd (#338) #339

Merged
merged 3 commits into from
Oct 2, 2023
Merged

feat: add specifying app version in crd (#338) #339

merged 3 commits into from
Oct 2, 2023

Conversation

kosmoz
Copy link
Member

@kosmoz kosmoz commented Sep 26, 2023

No description provided.

@kosmoz kosmoz self-assigned this Sep 26, 2023
@kosmoz kosmoz linked an issue Sep 26, 2023 that may be closed by this pull request
[Feature]: Add the ability to set the app version via CRD spec #338
Closed
@kosmoz kosmoz force-pushed the 338-feature-add-the-ability-to-set-the-app-version-via-crd-spec branch from e9b261d to 4ec19e3 Compare September 27, 2023 08:49
@kosmoz kosmoz requested a review from pmig September 27, 2023 09:36
pmig
pmig requested changes Oct 2, 2023
View reviewed changes
Copy link
Member

@pmig pmig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic per se works perfectly, I'd suggest to but the main app version into the root of the custom resource.

Also adding the Collabora app version to the office app spec will make sense

@kosmoz kosmoz requested a review from pmig October 2, 2023 13:44
@pmig pmig merged commit c1f1334 into main Oct 2, 2023
3 checks passed
@pmig pmig deleted the 338-feature-add-the-ability-to-set-the-app-version-via-crd-spec branch October 2, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmig pmig pmig approved these changes

Assignees

@kosmoz kosmoz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Add the ability to set the app version via CRD spec
2 participants
@kosmoz @pmig