feat(Nextcloud): make maxChildProcesses configurable via crd (#347) #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmig
force-pushed
the
347-configurable-nextcloud-max-processes
branch
from
8622c20
to
b66b95b
Compare
Also the defaults have been increased as issues could arrise with multiple users and configured sync clients. Signed-off-by: Philip Miglinci <pmig@glasskube.eu>
pmig
force-pushed
the
347-configurable-nextcloud-max-processes
branch
from
b66b95b
to
9588a8e
Compare
kosmoz
reviewed
Oct 3, 2023
Comment on lines
47
to
49
| .replace("%start_servers%", (maxChildProcesses / 8).toString()) | ||
| .replace("%min_spare_servers%", (maxChildProcesses / 16).toString()) | ||
| .replace("%max_spare_servers%", (maxChildProcesses / 4).toString()) |
There was a problem hiding this comment.
These look like magic numbers. Would it make more sense to allow configuration of all of these parameters? (And maybe move them to a subresource? 🙃)
There was a problem hiding this comment.
They actually have a non trivial dependency as start_servers cannot be smaller than min_spare_servers and the relation should also match.
Signed-off-by: Philip Miglinci <pmig@glasskube.eu>
kosmoz
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #347