Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for creating velero schedules (#350) #351

Merged
merged 16 commits into from
Nov 9, 2023
Merged

feat: add support for creating velero schedules (#350) #351

merged 16 commits into from
Nov 9, 2023

Conversation

kosmoz
Copy link
Member

@kosmoz kosmoz commented Oct 3, 2023

No description provided.

@kosmoz kosmoz self-assigned this Oct 3, 2023
@kosmoz kosmoz linked an issue Oct 3, 2023 that may be closed by this pull request
[Feature]: Add support for Velero Schedules #350
Closed
@kosmoz kosmoz changed the title feat: add support for creating velero schedules feat: add support for creating velero schedules (#350) Oct 3, 2023
@kosmoz kosmoz force-pushed the 350-feature-add-support-for-velero-schedules branch 5 times, most recently from 2d237e8 to f38eb62 Compare October 5, 2023 10:35
@kosmoz kosmoz marked this pull request as ready for review October 5, 2023 15:22
@kosmoz kosmoz force-pushed the 350-feature-add-support-for-velero-schedules branch from f38eb62 to 25f96b0 Compare October 5, 2023 15:22
@kosmoz kosmoz force-pushed the 350-feature-add-support-for-velero-schedules branch 3 times, most recently from b65458d to b7460ce Compare October 23, 2023 15:35
@kosmoz kosmoz requested a review from pmig October 30, 2023 14:09
@kosmoz kosmoz force-pushed the 350-feature-add-support-for-velero-schedules branch 2 times, most recently from aefbbc1 to 6dd7ac9 Compare November 2, 2023 14:43
pmig
pmig requested changes Nov 8, 2023
View reviewed changes
Copy link
Member

@pmig pmig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The velero s3 path looks like: restic/matomo/config although the backup name is matomo.matomo-matomo maybe the dot will not be added to the backup path (which is not ideal)

beside that it works fine :-)

operator/src/main/kotlin/eu/glasskube/operator/apps/common/backup/BackupSpec.kt Outdated Show resolved Hide resolved
@kosmoz
Copy link
Member Author

kosmoz commented Nov 8, 2023 •
edited
Loading

The velero s3 path looks like: restic/matomo/config although the backup name is matomo.matomo-matomo maybe the dot will not be added to the backup path (which is not ideal)

So, I did some digging and it looks like this is a limitation of Veleros "File System Backup" component. When instructed to create a PodVolumeBackup during a backup, the BackupRepoReconciler ensures that a BackupRepository exists for the Pods namespace and the BackupStorageLocation of the Backup, using only the Pods namespace as part of the resticIdentifier (regardless of the uploaderType used).

I think the only workaround for this might be to create a BackupRepository before any Backups are scheduled, but I'm not sure if that would work.

EDIT: Functionality wise, it should not matter though. It should be possible to restore individual volumes, even if they lie in the same restic repository.

@kosmoz
feat: add common backup spec and generic velero crds (#350)
92f6de8
@kosmoz
feat: add CompositeSecondaryToPrimaryMapper (#350)
f52dd18
@kosmoz
feat(Gitea): add backups to spec and velero dependent resources (#350)
6fde000
@kosmoz
chore: add velero permissions to cluster-role.yaml (#350)
dbc5e74
@kosmoz
feat: change getBackupAnnotations to consider backup spec (#350)
31abe32
@kosmoz
feat(Gitlab): add backups to spec and velero dependent resources (#350)
4425304
@kosmoz
feat(Glitchtip): add backups to spec and velero dependent resources (#…
30f5c85 
…350)
@kosmoz
feat(Keycloak): add backups to spec and velero dependent resources (#350
445a78d 
)
@kosmoz
fix: reduce logging verbosity
269b2fb
@kosmoz
feat(Matomo): add backups to spec and velero dependent resources (#350)
71112cc
@kosmoz
feat(Metabase): add backups to spec and velero dependent resources (#350
f0ef54f 
)
@kosmoz
feat(Nextcloud): add backups to spec and velero dependent resources (#…
e572bd1 
…350)
@kosmoz kosmoz force-pushed the 350-feature-add-support-for-velero-schedules branch from 6dd7ac9 to fb642bd Compare November 8, 2023 13:10
@kosmoz kosmoz requested a review from pmig November 8, 2023 13:12
@kosmoz kosmoz force-pushed the 350-feature-add-support-for-velero-schedules branch 2 times, most recently from 5fded7a to f50af3d Compare November 8, 2023 14:54
@kosmoz
Copy link
Member Author

kosmoz commented Nov 8, 2023

added Cloud Storage Backup CronJob for Gitlab and updated Cloud Storage Backup image tag to v0.2.1

@kosmoz kosmoz requested review from pmig and removed request for pmig November 8, 2023 14:55
@kosmoz kosmoz force-pushed the 350-feature-add-support-for-velero-schedules branch from f50af3d to 2b448dc Compare November 8, 2023 16:05
@pmig pmig merged commit dae7a34 into main Nov 9, 2023
3 checks passed
@pmig pmig deleted the 350-feature-add-support-for-velero-schedules branch November 9, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmig pmig pmig approved these changes

Assignees

@kosmoz kosmoz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Add support for Velero Schedules
2 participants
@kosmoz @pmig