Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Glitchtip): SMTP URL parsing (#368) #392

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

christophenne
Copy link
Member

No description provided.

@christophenne christophenne linked an issue Oct 30, 2023 that may be closed by this pull request
2 tasks
@christophenne christophenne force-pushed the 368-bug-glitchtip-smtp-url-parsing-error branch from 5619364 to 87f62e4 Compare October 30, 2023 16:41
@christophenne christophenne changed the title fix(Glitchtip): SMTP URL parsing (#368) WIP: fix(Glitchtip): SMTP URL parsing (#368) Oct 30, 2023
@christophenne christophenne marked this pull request as draft October 30, 2023 16:51
@christophenne christophenne force-pushed the 368-bug-glitchtip-smtp-url-parsing-error branch from 87f62e4 to 463252e Compare October 31, 2023 07:22
@christophenne christophenne marked this pull request as ready for review October 31, 2023 07:25
@christophenne christophenne changed the title WIP: fix(Glitchtip): SMTP URL parsing (#368) fix(Glitchtip): SMTP URL parsing (#368) Oct 31, 2023
Copy link
Member

@kosmoz kosmoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR indeed fixes the URL parsing bug.

There are two things I think should be improved before we are ready to merge this.

@christophenne christophenne force-pushed the 368-bug-glitchtip-smtp-url-parsing-error branch from 463252e to 4af997b Compare October 31, 2023 13:03
@christophenne christophenne force-pushed the 368-bug-glitchtip-smtp-url-parsing-error branch 3 times, most recently from a1f1186 to 04b972f Compare October 31, 2023 13:55
@christophenne christophenne force-pushed the 368-bug-glitchtip-smtp-url-parsing-error branch from 04b972f to 8890bad Compare October 31, 2023 15:10
@christophenne christophenne force-pushed the 368-bug-glitchtip-smtp-url-parsing-error branch 2 times, most recently from 84b76db to bfdc98e Compare October 31, 2023 15:52
@christophenne christophenne force-pushed the 368-bug-glitchtip-smtp-url-parsing-error branch from bfdc98e to 587aec2 Compare October 31, 2023 16:07
@kosmoz kosmoz merged commit 01c371e into main Oct 31, 2023
3 checks passed
@kosmoz kosmoz deleted the 368-bug-glitchtip-smtp-url-parsing-error branch October 31, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: GlitchTip SMTP URL parsing error
2 participants