-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Glitchtip): SMTP URL parsing (#368) #392
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
christophenne
force-pushed
the
368-bug-glitchtip-smtp-url-parsing-error
branch
from
October 30, 2023 16:41
5619364
to
87f62e4
Compare
christophenne
changed the title
fix(Glitchtip): SMTP URL parsing (#368)
WIP: fix(Glitchtip): SMTP URL parsing (#368)
Oct 30, 2023
christophenne
force-pushed
the
368-bug-glitchtip-smtp-url-parsing-error
branch
from
October 31, 2023 07:22
87f62e4
to
463252e
Compare
christophenne
changed the title
WIP: fix(Glitchtip): SMTP URL parsing (#368)
fix(Glitchtip): SMTP URL parsing (#368)
Oct 31, 2023
kosmoz
requested changes
Oct 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR indeed fixes the URL parsing bug.
There are two things I think should be improved before we are ready to merge this.
operator/src/main/resources/eu/glasskube/operator/apps/glitchtip/dependent/run.sh
Outdated
Show resolved
Hide resolved
operator/src/main/kotlin/eu/glasskube/operator/apps/glitchtip/dependent/GlitchtipConfigMap.kt
Outdated
Show resolved
Hide resolved
christophenne
force-pushed
the
368-bug-glitchtip-smtp-url-parsing-error
branch
from
October 31, 2023 13:03
463252e
to
4af997b
Compare
christophenne
force-pushed
the
368-bug-glitchtip-smtp-url-parsing-error
branch
3 times, most recently
from
October 31, 2023 13:55
a1f1186
to
04b972f
Compare
kosmoz
requested changes
Oct 31, 2023
...ator/src/main/kotlin/eu/glasskube/operator/apps/glitchtip/dependent/GlitchtipBinConfigMap.kt
Outdated
Show resolved
Hide resolved
christophenne
force-pushed
the
368-bug-glitchtip-smtp-url-parsing-error
branch
from
October 31, 2023 15:10
04b972f
to
8890bad
Compare
christophenne
force-pushed
the
368-bug-glitchtip-smtp-url-parsing-error
branch
2 times, most recently
from
October 31, 2023 15:52
84b76db
to
bfdc98e
Compare
christophenne
force-pushed
the
368-bug-glitchtip-smtp-url-parsing-error
branch
from
October 31, 2023 16:07
bfdc98e
to
587aec2
Compare
kosmoz
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.