Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add port and useSsl options and set default value for hostname … #464

Merged
merged 1 commit into from
Dec 16, 2023

Conversation

Anefu
Copy link
Contributor

@Anefu Anefu commented Dec 16, 2023

…and usePathStyle #461

Pull Request Template

Proposed Changes

We require all commits in this repository to adhere to the following commit message format.

<type>: <description> (#<issue number>)

[optional body]

The following <type>s are available:

  • fix (bug fix)
  • feat (includes new feature)
  • docs (update to our documentation)
  • build (update to the build config)
  • perf (performance improvement)
  • style (code style change without any other changes)
  • refactor (code refactoring)
  • chore (misc. routine tasks; e.g. dependency updates)

This format is based on Conventional Commits.
Please refer to the Conventional Commits specification for more details.

Description

These changes add the new options for GitLab Registry provided by #448

Related Issues

Screenshots (if applicable)

Please provide screenshots or GIFs that demonstrate the changes if your pull request includes visual updates.

Checklist

  • I have read and followed the contributing guidelines for this repository.
  • My code follows the coding style and standards of this project.
  • I have tested my changes locally.
  • I have added or updated necessary documentation (if applicable).
  • All new and existing tests passed.
  • My changes have been reviewed by at least one other contributor.
  • I have updated the README or relevant documentation (if applicable).
  • I have added proper labels to this PR (e.g., bug, enhancement, documentation, etc.).

Additional Information

Please provide any additional information that may be helpful in understanding or reviewing this PR.

Copy link
Member

@christophenne christophenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Classic, forgot about the docs - thanks for your PR @Anefu.

Now that I back-checked with the implementation, I think there might be a mistake there (useSsl should probably be default true, and hostname a nullable string). However let's go with this for now, I will have closer look again on monday back at work.

@christophenne christophenne merged commit eead370 into glasskube:main Dec 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve docs to add GitLab custom registry information
3 participants