fix: add label selector to all event sources #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to adding label selectors to all explicitly created event sources, all
KubernetesDependentResourcesnow have at least a label selector OR resource discriminator.When creating an informer event source using the
informerEventSourcefunction we now require a label selector to prevent accidentally creating anInformerEventSourcewithout one. If a use case for such an event source ever arises, I propose that we create a separate function for this to make the lack of a label selector more obvious.With this change, the operator can be started in Kubernetes clusters managed by OVH reliably again. I was able to run it 10+ times without encountering any errors. Also, startup time is greatly reduced (on my machine from 9-12s to about 4.5s).