Simplify process.receive/send and add receive_forever function #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpil
reviewed
Dec 4, 2024
src/gleam/erlang/process.gleam
Outdated
| Nil | ||
| } | ||
| @external(erlang, "gleam_erlang_ffi", "send") | ||
| pub fn send(subject: Subject(message), message: message) -> Nil |
There was a problem hiding this comment.
I just thought I would make it more simple. Instead of using raw_send which returns a DoNotLeak I call own gleam_erlang_ffi:send which pattern match the subject and returns nil directly.
But maybe I missed something? Do you need DoNotLeak if the erlang function returns nil
There was a problem hiding this comment.
Having more code in Gleam and verified by Gleam is better! The DoNotLeak pattern is very useful and to be encouraged.
There was a problem hiding this comment.
OK, I will revert this back to original.
|
Ok, I think I missed some proper documentation for receive_forever..... 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the use of process.select function when calling process.receive.
Also added receive_forever.
I am not really sure this is not sub-optimizing, but added it as a result of a performance discussion on the gleam discord channel.